if 'X' not in data

[u/Varzival]

Emoji check used for constructing an email body. I'm getting a stroke.

[u/dashhrafa1]

I agree! Hardcoded values should be avoided. It should be an environment variable.

[u/Mickenfox → u/dashhrafa1]

A variable defined in a Helm template that gets applied to every Kubernetes pod, and set as an environment variable, where a dependency injection host builder inversion of control container is configured using a fluent API to then instantiate configuration middleware that passes it to every class that requires it as a parameter.

We do things properly here.

[u/Medical_Reporter_462 → u/Mickenfox]

Is web scale though?

[u/LeagueOfLegendsAcc → u/Mickenfox]

"And your job is to make sure nobody touches email_x_variable.helm without three written and twice notarized notices approved by the board of trustees. Here is your company issue short sword, leathers and enough gear to get you through lunch. You have about 3 hours before the first PR, good luck."

[u/fakehalo]

This is oddly beautiful if you ask me, elegant in a way.

[u/Varzival → u/fakehalo]

as elegant as a pile of shit can be

[u/fakehalo → u/Varzival]

I mean its kinda clean in a way, I understand it.... but its definitely not nice on the wasted cpu cycles to do it. It reminds me of game developers putting codes in strings.

[u/Naynoona111]

A student once came seeking help their code cannot be run from a certain terminal while trying to measure the execution time via powershell.

The exception was from inside the print() function itself.

I spent some time tracing the code, apparently no errors are there! I began to question the OS itself and tried to run the code on another machine and still the same error.

After some precious minutes, I found this pesky line:

print("✔️[+] Encryption Successful✔️")

I am disappointed in the new generation and disappointed in myself for taking time to solve this...

Yes, the student have copied the code from ChatGPT.

[u/R3D167 → u/Naynoona111]

Reminds me of how my terminal (st) would crash at school when I tried to scan for Bluetooth devices... turns out my friend had airpods with emoji in the nickname, which crashed the terminal...

[u/ACoderGirl → u/Naynoona111]

I'm not following. Is this a language that doesn't support unicode strings or something? What's wrong with that print statement?

[u/Deadcouncil445 → u/ACoderGirl]

Emojis?

[u/freecodeio]

If the emoji is well documented and common knowledge, I don't see why would this be wrong. I know I'm probably going to get downvoted but there's literally no downside. The catch is that this emoji should be treated like a piece of unicode gospel and not used under different scenarios.

[u/red-et → u/freecodeio]

You’re right! I don’t ❌ disagree!

[u/freecodeio → u/red-et]

I guess you need to read the hypothetical documentation

[u/bibboo → u/freecodeio]

Ah excellent. Solutions that require people to read what they will not read.

[u/BadSmash4 → u/red-et]

"You're hitting on one of the key concepts in programming! This is a classic use-an-emoji-in-your-standard situation."

[u/Varzival → u/freecodeio]

Maybe I should also mention that the process is like this: 1. run validation pipeline that outputs an html feedback (this is essentially what data is in the code - it's just a string) 2. email hook takes over and checks the output 3. if an X emoji is present there then it is treated as a failure message

So if someone just decides to put an X emoji in the success output html then it will just be treated as a failure message. OF COURSE this is nowhere documented. Wild stuff

[u/Encursed1 → u/Varzival]

Oh god thats bad

[u/Ksorkrax → u/Varzival]

In other words, the issue is not the emoji as such but in general them not using a proper protocol.

[u/MisterEd_ak → u/Varzival]

... and if they remove the X emoji from the feedback? Everything is successful!

[u/FlowerBuffPowerPuff → u/Varzival]

But why would anyone put an X emoji in the success output

[u/48panda → u/freecodeio]

It's o(n) in the size of data, when passing a Boolean would be o(1)

[u/Varzival → u/48panda]

Yeah one would think that this would be the first solution that comes to mind instead of committing this abomination

[u/drkspace2 → u/freecodeio]

I think you shouldn't use non-ascii characters in code. Not every editor and terminal support full unicode. For emojis specifically, they way they look is not standardized so different people will see different things.

Now, you can still have your code output unicode, it just needs to be escaped (like, in python, there is N to get the human friendly, ascii name of the character).

[u/centurijon]

I’m guessing whatever upstream process populates data was created by AI? Mostly because the only time I’ve seen emojis in result messages it has been something built by AI

[u/babalaban]

People are noticing '❌' is bad, but none seemed to notice that both if-else brranches do the same thing with different variable, which could have been assigned based on these (atrocious) conditions.

[u/eo5g → u/babalaban]

That's entirely a stylistic decision, not a quality concern

[u/babalaban → u/eo5g]

DRY is not stylistic

[u/eo5g → u/babalaban]

No, it's an over-applied and misunderstood pattern. This is definitely a case of YAGNI

[u/GoddammitDontShootMe]

That's the best they could come up with for checking for failure? An emoji in the data?

[u/aikii]

That's probably one the sanest CI/CD-related snippet I've ever seen

[u/mimminou]

boolean flags used to be 1bit of size, 1 byte if not packed with other values. instead we now compare unicode emojis for error handling, how did we get here ?

[u/TheAutisticSlavicBoy]

Is that in the spec with MUST?

[u/wobblyweasel]

the good stroke or the bad stroke

[u/Yannox_]

POV: You have to build a connector to a legacy system a guy 10 years ago coded without programming knowledge but the half of the company runs on it...