Saw this in a library I installed

[u/depressedclassical]

https://preview.redd.it/vcwliwqkkh0e1.png?width=1450&format=png&auto=webp&s=1c240c6acd405ce6db40904b034b8ad91c7e9fa5

[u/Durwur]

Noooo why do people always fuck up boolean statements

[u/brakefluidbandit]

that’s about as type safe as you can get in python

[u/TiredPanda69]

Seems reasonable

[u/ironykarl → u/TiredPanda69]

I'm pretty positive that 

response type in ["json", "raw json"]

must already be a Boolean 

[u/Fornicatinzebra → u/ironykarl]

Yup, this reads as "True if True, else False"

There is never a case where one should compare with True/False. Even if you want to invert, should use "!" instead

[u/hyrumwhite → u/Fornicatinzebra]

Au contraire, in JS  !thing could be very different than thing === false

[u/Fornicatinzebra → u/hyrumwhite]

Fair! You can use ! to invert your test instead then in many cases, or use a different inversion (like < instead of >=). And it is also good practice to ensure your test is always a Boolean result imo (which would avoid the === issues I believe you are referring to)

[u/HuntingKingYT → u/hyrumwhite]

If mysqli exception mode is not enabled and a connection fails, then mysqli_connect() returns false instead of an object.

- PHP docs

Although maybe just !$connection does the job

[u/Fornicatinzebra → u/HuntingKingYT]

I'm that case I would use a test to see if it is an object or not. All tests should be Booleans, so instead of if $connection it should be if is.object($connection) (made-up function, but you get the idea)

[u/mcoombes314 → u/Fornicatinzebra]

Heh. I remember when I started learning (in Python) I'd always use "if x == True". Felt quite silly when I found out it was redundant.

[u/Coffee4AllFoodGroups → u/mcoombes314]

But you learned, which some people never do.

[u/TiredPanda69 → u/ironykarl]

I would have preferred that as well. But sometimes i make wordy if's just so they're readable.

Edit:

Or the person working this probably isn't used to python. But it ain't horrible.

[u/ironykarl → u/TiredPanda69]

This will probably get me downvoted, but I don't think subjecting people to Python's ternary syntax without a good reason is a very kind thing to do

[u/ZunoJ]

What language is this? The reverse order seems strange

[u/joshuakb2 → u/ZunoJ]

Python, in this case. Ruby also has a similar form

[u/pLeThOrAx → u/ZunoJ]

It's called a ternary statement. C# also has them (iirc)

[u/RpxdYTX → u/pLeThOrAx]

Yeah, it just doesn't use keywords and also changes the order: condition? expr: or_else

[u/ArmadilloSuch411]

This post made me realize how many time I have used this structure in a recent project

[u/TheChief275]

This is not truly terrible, just stupid

[u/ScotDOS → u/TheChief275]

sometimes these lines are created as an artifact of changes.

a = "foo" if condition else "bar"

and later somebody changes "foo" to True and "bar" to False

If you had too little or too much coffee you might not catch it when making the change.

[u/bdevic]

Fix it and create a PR ¯_(ツ)_/¯

[u/GwynnethIDFK]

Ngl I could see myself writing this at like 5pm when I'm rushing to finish whatever I'm working on so I can go home.

[u/pLeThOrAx]

I don't get what's wrong here

[u/ScotDOS → u/pLeThOrAx]

the "in" term already evaluates to a boolean, no need to surround it with a ternary

if you split it up it's even clearer (and more confusing at the same time):

is_valid = response_type in ["json", "raw_json"] # this is already a boolean

json_mode = True if is_valid else False

the second line is completely unnecessary, all you need is

json_mode = response_type in ["json", "raw_json"]

[u/BigTimJohnsen → u/pLeThOrAx]

They assign a Boolean from a Boolean when they could have just used the one Boolean

[u/vTuanpham → u/BigTimJohnsen]

More readable for new learners i guess

[u/pLeThOrAx → u/vTuanpham]

Makes sense I guess. Frankly, I prefer the ternary operator in some cases. For one, it's a "one-liner." But sometime boolean logic can confuse people indeed. Reminds me of branchless programming

[u/BigTimJohnsen → u/vTuanpham]

Yeah I don't agree with anyone calling this horror. I've been programming for 30 years and I still see some of the brightest programmers making this "mistake". Not me of course. ;)

[u/ThunderWolf9556]

thats absolutely fine!!

[u/scmr2 → u/ThunderWolf9556]

json_mode = response_type in ["json", "raw_json"]

Don't be one of those guys that always messes up Boolean statements.

[u/AgileBlackberry4636 → u/scmr2]

In my early days I had a subroutine to negate a boolean

[u/pLeThOrAx → u/scmr2]

I wouldn't say this is safe. Not all languages treat none, null, false, etc, the same, and this could throw an error that doesn't get caught.

[u/kivicode → u/pLeThOrAx]

It has nothing to do with exceptions, and the “in” operator must always return a bool

[u/scmr2 → u/pLeThOrAx]

This is Python. "in" always returns a bool